[2.3] Do not override application-specified "com.sun.faces.enableDistributable" value #5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeshnas93
force-pushed
the
JBEAP-26020
branch
from
4ddd96a
to
3947e30
Compare
soul2zimate
reviewed
Nov 23, 2023
Indeed. It should be the exact same change. |
sudeshnas93
force-pushed
the
JBEAP-26020
branch
from
a1f6d38
to
a79a196
Compare
|
Code changes have been made accordingly. Please review. |
|
@sudeshnas93 Please make sure you use the same email as your Eclipse account so the ECA check passes |
|
I have used the same email address as that of Eclipse account and updated the ECA. Can this test be rerun again? |
mnriem
approved these changes
Dec 4, 2023
|
Hi @BalusC, could you please review the changes? |
BalusC
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mojarra defines a number of initialization parameters. While "com.sun.faces.enableDistributable" is one of them, Mojarra automatically overrides any existing setting provided by the application.
If a web application wanted explicitly disable this for a distributable web application, it would normally add a servlet context parameter within web.xml.
e.g.
However, the ConfigureListener auto-enables the com.sun.faces.enableDistributable configuration property whenever it see that the tag in web.xml, overriding any custom setting.
I would expect Mojarra to respect the setting defined by the application, and only provide a default value if no value was specified.